Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default MLFlow tracking cannot set if tracking the config artifacts #7601

Closed
binliunls opened this issue Apr 1, 2024 · 0 comments · Fixed by #7604
Closed

Default MLFlow tracking cannot set if tracking the config artifacts #7601

binliunls opened this issue Apr 1, 2024 · 0 comments · Fixed by #7604
Assignees

Comments

@binliunls
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When running a typical MONAI model zoo bundle training with tracking="mlflow", it will always try to record all the config files as artifacts due to this line. If the execute_config is set, it will track config files in the specific path. When the execute_config parameter is not set it will track the default path.

Describe the solution you'd like
The execute_config parameter should be a bool| string type, so that users can set it as False, if they do not want to record any configs. They can set the parameter to True to record the default path or to a real path if config files are saved in other places.

@binliunls binliunls self-assigned this Apr 1, 2024
@KumoLiu KumoLiu mentioned this issue Apr 2, 2024
7 tasks
KumoLiu added a commit that referenced this issue Apr 12, 2024
Fixes #7601 .

### Description

Support not save artifacts.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: binliu <[email protected]>
Co-authored-by: Nic Ma <[email protected]>
Co-authored-by: YunLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant