Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WarmupCosineSchedule add end_lr #6527

Closed
ibro45 opened this issue May 17, 2023 · 0 comments · Fixed by #6662
Closed

WarmupCosineSchedule add end_lr #6527

ibro45 opened this issue May 17, 2023 · 0 comments · Fixed by #6662
Assignees
@KumoLiu
Labels
Contribution wanted Feature request good first issue Good for newcomers

Comments

@ibro45
Copy link
Contributor

ibro45 commented May 17, 2023

LinearLR and ExponentialLR already have the end_lr argument, It would definitely be useful in WarmupCosineSchedule too.
@KumoLiu KumoLiu self-assigned this Jun 27, 2023
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Jun 27, 2023
@KumoLiu
fix Project-MONAI#6527
86e1708 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu mentioned this issue Jun 27, 2023
Merged
7 tasks
wyli pushed a commit that referenced this issue Jun 27, 2023
@KumoLiu
Add end_lr in WarmupCosineSchedule (#6662)
60620e4 
Fixes #6527 .

### Description

Add `end_lr` in `WarmupCosineSchedule`

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KumoLiu KumoLiu

Labels
Contribution wanted Feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add end_lr in WarmupCosineSchedule KumoLiu/MONAI
3 participants
@wyli @ibro45 @KumoLiu