Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Publish version 0.6.0-alpha #484

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

marien-probesys
Copy link
Member

@marien-probesys marien-probesys commented Nov 23, 2023

Related issue(s)

N/A

How to test manually

N/A

Additional note

A lot of assets files have been deleted. This is because Vite inlines the assets when using the ES format (that we enabled when upgrading to Vite 5).

Some impacts:

  • there are fewer assets to load BUT;
  • the CSS file is bigger than before (53Ko vs. 35Ko, +50%);
  • the images are always loaded via the CSS file, while before they were loaded in parallel, only when needed;
  • there is no longer cache for the images.

I'm a bit annoyed by the situation, but I think the size of the CSS is still correct (I mean, by comparison to other projects using some heavy frameworks).

More information in vitejs/vite#4454

It seems that this plugin is able to extract assets instead of inlining them (not tested): https://github.com/laynezh/vite-plugin-lib-assets/tree/main

Checklist

  • code is manually tested
  • permissions / authorizations are verified
  • interface works on both mobiles and big screens
  • interface works in both light and dark modes
  • accessibility has been tested
  • tests are up-to-date
  • locales are synchronized
  • copyright notices are up-to-date
  • documentation is up-to-date (including migration notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant