Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new entities.json file, extracted using node-minecraft-extractor #90

Merged
merged 5 commits into from
Jan 10, 2016

Conversation

rom1504
Copy link
Member

@rom1504 rom1504 commented Jan 10, 2016

from mcdevs and mcwiki

about #72

@Gjum can you look at this ?

@Gjum
Copy link
Member

Gjum commented Jan 10, 2016

There are two Item Frames (IDs 2 and 71), but no Dropped Items in the new json files. I remember Dropped Item being ID 2, so check your extractor on that.

Also, there should be some kind of sorting so the diff doesn't blow up each time something changes, and that humans can look up entries quickly. is sorted by type and id

@rom1504
Copy link
Member Author

rom1504 commented Jan 10, 2016

It is sorted, just not the same order as before.
It currently puts the mob first and then the object. Appart from that it's sorted by id.
(it's used to be completely sorted by id which wasn't making that much sense)

I fixed the dropped item thing.

@Gjum
Copy link
Member

Gjum commented Jan 10, 2016

LGTM

metadata can be a different PR if you want.

rom1504 added a commit that referenced this pull request Jan 10, 2016
new entities.json file, extracted using node-minecraft-extractor
@rom1504 rom1504 merged commit b66f846 into master Jan 10, 2016
@rom1504 rom1504 deleted the new_entities branch January 10, 2016 19:01
@Gjum
Copy link
Member

Gjum commented Jan 10, 2016

On further inspection there still seem to be some issues:
curl https://raw.githubusercontent.com/PrismarineJS/minecraft-data/master/data/1.8/entities.json | grep -oP '(?<=displayName": ")[^"]*' | sort | uniq -c
gives 3 Minecart and 2 Falling block

EDIT: already merged, changed command from new_entities to master

There is also no Falling Dragon Egg at ID 74, but Falling block.

@rom1504
Copy link
Member Author

rom1504 commented Jan 10, 2016

Yes but I'm not sure what to do about this. The minecart thing is due to wiki.vg having old entities (see http://wiki.vg/Entities#Objects) which mcwiki doesn't have, and I'm taking the names from mcwiki.

Same thing about falling block, mcwiki says it's the same entity ... (http://minecraft.gamepedia.com/Data_values/Entity_IDs : falling block has sand and dragon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants