highlightAll accepting an element to query

[itsadrake]

Currently, the highlightAll function queries document for all highlightable elements, then calls highlightElement on all of them. Sometimes we may wish to do so for a specific element deeper down the DOM tree.
There is already a highlightElement function, but it exits for elements that are not immediately highlightable. The highlightAll function seems to be a good candidate for a simple generalisation.
If no element is passed, the function can default to querying document, hopefully requiring minimal changes to existing code.

[apfelbox]

This is a BC break. If you add the parameter as the last one, it would be BC safe. Also, I would name the parameter rootElement.

[itsadrake]

That would make the argument order inconsistent with that of highlightElement. Perhaps we could avoid breakage by introducing a new function altogether? Perhaps one called highlightChildren or some such.

[apfelbox]

Ah, you are right.

I could live with a new function. Maybe something more modern (promises, anyone)? So that we could slowly move all code to the new functions - this one could automatically and intelligently handle both a single element or a set of elements.

[LeaVerou]

Um, not sure I follow why highlightElement doesn’t suffice in this case?

[itsadrake]

Because highlightElement does not highlight any of its children, and it would be nice if we could query a node other than document.

[tanakahisateru]

I created another pull-request #1230

[Golmote]

#1230 fixed this issue in a more compatible way.