Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated changelog for 1.19.0 #2169

Merged
merged 10 commits into from
Jan 13, 2020
Merged

Updated changelog for 1.19.0 #2169

merged 10 commits into from
Jan 13, 2020

Conversation

RunDevelopment
Copy link
Member

(Not linkified, no date)

This also includes a small update to the changelog generation to account for dependencies.js.

@mAAdhaTTah
Copy link
Member

I think this needs to be 1.19.0. We're introducing new languages, which is a new feature, so minor version bump.

@RunDevelopment RunDevelopment changed the title Updated changelog for 1.18.1 Updated changelog for 1.19.0 Jan 11, 2020
@mAAdhaTTah
Copy link
Member

Set the date to today before merging.

@RunDevelopment
Copy link
Member Author

Is that a request or a statement?

@RunDevelopment
Copy link
Member Author

(This might sound passive aggress, but it isn't meant to.)
I intentionally publish these changelog branches in the PrismJS repository and not in my fork, so other maintainers can easily commit their own changes (maybe even using GitHub's in-browser editor). I do this because I don't want to miss a message like this causing a release to be delayed and you to be annoyed.

@mAAdhaTTah mAAdhaTTah merged commit dc136fd into master Jan 13, 2020
@mAAdhaTTah mAAdhaTTah deleted the changelog-1.18.1 branch January 13, 2020 13:37
@mAAdhaTTah
Copy link
Member

Hah, no worries. The thought at the time was to update the date, merge, then I'd be able to pull master & publish w/o needing to update anything, but I fell asleep before I saw this. Anyway, it's published, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants