Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Swift 'protocol' keyword #1375

Closed
wants to merge 1 commit into from
Closed

Fix Swift 'protocol' keyword #1375

wants to merge 1 commit into from

Conversation

ileitch
Copy link
Contributor

@ileitch ileitch commented Mar 31, 2018

Change Protocol to protocol.

@Golmote
Copy link
Contributor

Golmote commented Apr 4, 2018

Hi and thanks for contributing!
Can you please run gulp to generate the minified version of the component and include it in this PR.
Also, you'll have to update the test file for keywords in Switch.

@mAAdhaTTah
Copy link
Member

@ileitch Would you be able to make the change suggested by @Golmote? If not, I'd be happy to pick this up. Let me know.

@mAAdhaTTah mAAdhaTTah changed the base branch from gh-pages to master June 5, 2018 20:14
@ileitch
Copy link
Contributor Author

ileitch commented Jun 6, 2018

@mAAdhaTTah You're welcome to take it. Prism is also missing the extension keyword.

@mAAdhaTTah mAAdhaTTah mentioned this pull request Jun 12, 2018
Merged
@ileitch ileitch deleted the patch-1 branch June 17, 2018 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement language-definitions needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ileitch @Golmote @mAAdhaTTah