Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunTelemetry start span uses run name instead of flow/task name #16389

Conversation

jeanluciano
Copy link
Contributor

@jeanluciano jeanluciano commented Dec 13, 2024

This PR makes is so we only use run name for span creation. Summary of changes:

  • RunTelemetry._start_span only uses run name to create spans.
  • Updates engine code to not used flow/task name.
  • Updates unit test to reflect this changes by using flow_run_name and task_run_name

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #16389 will not alter performance

Comparing jean/cloud-854-use-prefectrunname-instead-of-prefectflowtaskname-in-client (e602132) with main (9924f8f)

Summary

✅ 3 untouched benchmarks

@jeanluciano jeanluciano marked this pull request as ready for review December 16, 2024 19:40
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making sense to me! one question about the stray file

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! It might be worthwhile to add a test where the run name uses a string template to ensure the formatted name is used correctly, but that's non-blocking.

@jeanluciano jeanluciano merged commit 5f5e4a6 into main Dec 31, 2024
38 checks passed
@jeanluciano jeanluciano deleted the jean/cloud-854-use-prefectrunname-instead-of-prefectflowtaskname-in-client branch December 31, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants