-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RunTelemetry start span uses run name instead of flow/task name #16389
RunTelemetry start span uses run name instead of flow/task name #16389
Conversation
CodSpeed Performance ReportMerging #16389 will not alter performanceComparing Summary
|
…/cloud-854-use-prefectrunname-instead-of-prefectflowtaskname-in-client
…-prefectflowtaskname-in-client
…/cloud-854-use-prefectrunname-instead-of-prefectflowtaskname-in-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making sense to me! one question about the stray file
…-prefectflowtaskname-in-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! It might be worthwhile to add a test where the run name uses a string template to ensure the formatted name is used correctly, but that's non-blocking.
…/cloud-854-use-prefectrunname-instead-of-prefectflowtaskname-in-client
This PR makes is so we only use run name for span creation. Summary of changes:
RunTelemetry._start_span
only uses run name to create spans.flow_run_name
andtask_run_name
Checklist
<link to issue>
"mint.json
.