Support --credentials
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakekaplan
requested review from
jeanluciano
and removed request for
chrisguidry
jakekaplan
commented
Feb 4, 2025
| @@ -115,6 +120,37 @@ async def set_deployment_id(self, storage_id: UUID, deployment_id: UUID): | |||
| json={"deployment_id": str(deployment_id)}, | |||
| ) | |||
|
|
|||
| async def create_credentials_secret(self, name: str, credentials: str): | |||
| try: | |||
There was a problem hiding this comment.
I probably am going to see if I can make a single endpoint that just works this way, there is some the back and forth here is noticeable. In the worst case scenario it's 4 extra calls because you've never add credentials for this repo.
jeanluciano
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support a
--credentialsoption on deployment. This will create a secret block if one does not exist using the repo's name and owner. If one does it exists, it will update it with the newly passed credentials.Example Usage:
This doesn't AUTOMAGICALLY use credentials for that repo if it exists and you don't provide them. That's a future story.
CLOSES ENG-1232