Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes ls work again after adding work_pool_name #55

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

chrisguidry
Copy link
Contributor

In previous work, I added the work_pool_name to the Deployment, but
it isn't actually part of all Deployment responses (like the filter
responses). This splits the core object from the DeploymentResponse
which has the additional info when we do a GET on the deployment.

In previous work, I added the `work_pool_name` to the `Deployment`, but
it isn't actually part of all `Deployment` responses (like the filter
responses).  This splits the core object from the `DeploymentResponse`
which has the additional info when we do a `GET` on the deployment.
Copy link
Contributor

@jeanluciano jeanluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisguidry chrisguidry merged commit 428118c into main Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants