Adds deletecommand and remove flag.
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakekaplan
reviewed
Feb 14, 2025
src/prefect_cloud/cli/root.py
Outdated
| @@ -242,7 +242,7 @@ async def schedule( | |||
| help="Name or ID of the deployment to schedule", | |||
| autocompletion=completions.complete_deployment, | |||
| ), | |||
| schedule: str = typer.Argument( | |||
| schedule: str = typer.Option( | |||
There was a problem hiding this comment.
I think doing it like this would mean you need to specify something for --schedule in addition to --remove. This may need to be optional and then you check that only either --schedule or --remove is selected.
If that feels weird, we could maybe try making it a different command entirely
There was a problem hiding this comment.
Yeah I think we should do something like prefect-cloud unschedule deployment/name
There was a problem hiding this comment.
That sounds good to me. That's my fault for suggesting --remove I think I talked myself in circles here...
There was a problem hiding this comment.
I don't even like --run but that's just me
jakekaplan
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
deletecommand for deleting deployments and aremoveflag for deleting a deployments schedules. It also removes thepauseandresumedeployment schedule functions.