respect `GitHubFileRef` shorthand #37

zzstoatzz · 2025-02-12T03:35:58Z

stacked on #35 (all changes specific to this PR are in 87d7f0d)

tries shorthand for GitHubFileRef or falls back to existing behavior

» alias prfx
prfx=prefect-cloud

» prfx deploy print_info -f gh/zzstoatzz/prefect-pack/flows/hello.py
Deployed print_info! 🎉
└─►
https://app.prefect.cloud/account/9b649228-0419-40e1-9e0d-44954b5c0ab6/workspace/e49488be-6d30-4980-94b2-a82a5edbb19c/deployments/deployment/74b5f9d4-aaa9-4792-b2ba-52688394970b
Run it with:
└─► prefect-cloud run print_info/print_info

and adds some tests

zzstoatzz · 2025-02-12T03:36:27Z

src/prefect_cloud/github.py

+    @classmethod
+    def _try_shorthand(cls, url: str) -> "GitHubFileRef":
+        if not url.startswith("gh/"):
+            raise InvalidGitHubURL("Not a shorthand URL")
+
+        parts = url[3:].split("/")  # Remove 'gh/' prefix
+        if len(parts) < 2:  # Need at least owner/repo
+            raise InvalidGitHubURL("Invalid shorthand format")
+
+        owner = parts[0]
+        repo = parts[1]
+        branch = "main"
+
+        if "@" in owner:
+            owner, branch = owner.split("@")
+        elif "@" in repo:
+            repo, branch = repo.split("@")
+
+        filepath = "/".join(parts[2:]) if len(parts) > 2 else ""
+        return cls(
+            owner=owner,
+            repo=repo,
+            branch=branch,
+            filepath=filepath,
+            ref_type="blob",
+        )


update test ope

zzstoatzz commented Feb 12, 2025

View reviewed changes

zzstoatzz force-pushed the gh branch 2 times, most recently from f05c96a to 87d7f0d Compare February 12, 2025 03:53

zzstoatzz added 3 commits February 12, 2025 08:20

merge conflict

71763f0

merge conflict

d75eab9

help

d7cb0ae

update test ope

zzstoatzz force-pushed the gh branch from 87d7f0d to d7cb0ae Compare February 12, 2025 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

respect `GitHubFileRef` shorthand #37

respect `GitHubFileRef` shorthand #37

zzstoatzz commented Feb 12, 2025 •

edited

Loading

zzstoatzz Feb 12, 2025

respect GitHubFileRef shorthand #37

Are you sure you want to change the base?

respect GitHubFileRef shorthand #37

Conversation

zzstoatzz commented Feb 12, 2025 • edited Loading

zzstoatzz Feb 12, 2025

Choose a reason for hiding this comment

respect `GitHubFileRef` shorthand #37

respect `GitHubFileRef` shorthand #37

zzstoatzz commented Feb 12, 2025 •

edited

Loading