Add more urls to github + don't use raw api #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1337 `raw.githubusercontent.com` doesn't update fast
we should maybe us the github api for this instead of the raw url. |
chrisguidry
reviewed
Feb 12, 2025
Comment on lines
+27
to
+35
| Handles various GitHub URL formats: | ||
| - https://github.com/owner/repo/blob/branch/path/to/file.py | ||
| - https://github.com/owner/repo/tree/branch/path/to/file.py | ||
| - github.com/owner/repo/blob/a1b2c3d/path/to/file.py (commit SHA) | ||
| - github.com/owner/repo/blob/path/to/file.py (uses first path component as ref) | ||
|
|
||
| Also handles tree URLs: | ||
| - https://github.com/owner/repo/tree/branch/path/to/dir | ||
| - github.com/owner/repo/tree/a1b2c3d/path/to/dir (commit SHA) | ||
| - github.com/owner/repo/tree/path/to/dir (uses first path component as ref) |
There was a problem hiding this comment.
I'd love to surface this up to the --help of the deploy command
chrisguidry
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSES ENG-1337
https://raw.githubusercontent.com/because those seem like they can be cached indefinitely