-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gets MyPy pre-commit
hook to run on all files.
#22
Gets MyPy pre-commit
hook to run on all files.
#22
Conversation
ENG-1335 Fix mypy issues in precommit hook
We are currently getting the mypy errors below when running the hook on the entire repo.
|
…o jean/eng-1335-fix-mypy-issues-in-precommit-hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES
.pre-commit-config.yaml
Outdated
files: | | ||
(?x)^( | ||
src/prefect_cloud/.* | ||
)$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, could we also do the test suite? Maybe just remove the filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's a lot of noise, we could do that in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope I like that better.
This PR updates
.pre-commit-config.yaml
to run on thesrc
directory. It all fixes all current errors in CI.