Adds support for picking a non-prd Prefect Cloud environment #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisguidry
commented
Feb 7, 2025
| ) | ||
|
|
||
| app.console.print( | ||
| f"Run it with: \n $ prefect deployment run {function}/{deployment_name}", | ||
| style="blue", |
There was a problem hiding this comment.
These blue styles are pretty dark on Ubuntu's default theme. Dialing them back for now
jakekaplan
reviewed
Feb 7, 2025
| # TODO: Get this configuration from the user's environment if possible | ||
| CLOUD_UI_URL = "https://app.prefect.cloud" | ||
| CLOUD_API_URL = "https://api.prefect.cloud/api" | ||
| if os.environ.get("CLOUD_ENV") in ("prd", "prod", None): |
There was a problem hiding this comment.
There a pydantic settings file we could use for this instead of getting it directly?
There was a problem hiding this comment.
Good question, I've felt a little off-kilter with where the settings should be with this one, since we're kinda piggybacking on ~/.prefect/profiles.toml. I figured this was only for us devs, so we didn't want to expose this as a user-facing option (like as a --cloud-env switch or something, which is how I started)
jakekaplan
approved these changes
Feb 7, 2025
chrisguidry
added a commit
that referenced
this pull request
Feb 7, 2025
* Autocompletes deployments on `run`, `schedule`, and friends There's still more of a delay here than I'd like, even with the caching. I think we are starting to get some import time creep that I'll dig into more over time. * Fixing up auth tests * Adds support for picking a non-prd Prefect Cloud environment (#15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.