Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

Add AirbyteServer block #40

Merged
merged 16 commits into from
Nov 16, 2022
Merged

Add AirbyteServer block #40

merged 16 commits into from
Nov 16, 2022

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Nov 14, 2022

Adds the AirbyteServer block to handle nginx authentication for OSS instance in AirbyteClient and store config info about the instance running airbyte.

This PR alters the tasks in this collection to accept an AirbyteServer instead of the individual fields, so these are breaking changes.

This PR also adds a deprecation warning to export_configuration, as the underlying API endpoint was removed from OSS airbyte as of airbyte v0.40.7

Closes #39
Closes #21

Example

Checklist

  • This pull request includes tests or only affects documentation.
  • Summarized PR's changes in CHANGELOG.md

@zzstoatzz zzstoatzz requested a review from a team November 14, 2022 22:37
@zzstoatzz zzstoatzz self-assigned this Nov 14, 2022
@zzstoatzz zzstoatzz changed the title Add AirbyteServer block **[breaking-changes]** Add AirbyteServer block [breaking-changes] Nov 14, 2022
@ahuang11
Copy link
Contributor

Before I forget, I think we should add a changelog with the usual items and also highlight breaking changes in the first line.

Copy link
Contributor

@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Mostly questions

prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/configuration.py Outdated Show resolved Hide resolved
prefect_airbyte/server.py Show resolved Hide resolved
prefect_airbyte/server.py Show resolved Hide resolved
prefect_airbyte/server.py Show resolved Hide resolved
prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/server.py Show resolved Hide resolved
prefect_airbyte/server.py Show resolved Hide resolved
prefect_airbyte/server.py Show resolved Hide resolved
prefect_airbyte/server.py Outdated Show resolved Hide resolved
@ahuang11 ahuang11 requested a review from desertaxle November 14, 2022 23:27
prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/client.py Show resolved Hide resolved
prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/configuration.py Outdated Show resolved Hide resolved
prefect_airbyte/server.py Show resolved Hide resolved
Copy link
Contributor

@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/configuration.py Show resolved Hide resolved
prefect_airbyte/connections.py Outdated Show resolved Hide resolved
prefect_airbyte/connections.py Show resolved Hide resolved
prefect_airbyte/server.py Outdated Show resolved Hide resolved
prefect_airbyte/client.py Show resolved Hide resolved
prefect_airbyte/server.py Show resolved Hide resolved
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're close enough to not making any breaking changes that I propose we don't make any. We can deprecate, continue with 0.1.x version releases, and then remove them in 0.2.0 when we've gotten this collection to our short term target state.

prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/connections.py Show resolved Hide resolved
prefect_airbyte/connections.py Show resolved Hide resolved
prefect_airbyte/connections.py Outdated Show resolved Hide resolved
prefect_airbyte/connections.py Outdated Show resolved Hide resolved
prefect_airbyte/client.py Show resolved Hide resolved
@zzstoatzz zzstoatzz requested a review from desertaxle November 16, 2022 18:09
prefect_airbyte/client.py Outdated Show resolved Hide resolved
prefect_airbyte/configuration.py Outdated Show resolved Hide resolved
prefect_airbyte/connections.py Outdated Show resolved Hide resolved
prefect_airbyte/client.py Outdated Show resolved Hide resolved
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@desertaxle desertaxle dismissed ahuang11’s stale review November 16, 2022 19:58

Requested changes addressed

@desertaxle desertaxle changed the title Add AirbyteServer block [breaking-changes] Add AirbyteServer block Nov 16, 2022
@zzstoatzz zzstoatzz merged commit 490a4c8 into main Nov 16, 2022
@zzstoatzz zzstoatzz deleted the add-block branch November 16, 2022 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for basic auth to secure OSS Airbyte Add AirbyteServer block
3 participants