-
Notifications
You must be signed in to change notification settings - Fork 8
Add AirbyteServer
block
#40
Conversation
AirbyteServer
block **[breaking-changes]**AirbyteServer
block [breaking-changes]
Before I forget, I think we should add a changelog with the usual items and also highlight breaking changes in the first line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Mostly questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're close enough to not making any breaking changes that I propose we don't make any. We can deprecate, continue with 0.1.x version releases, and then remove them in 0.2.0 when we've gotten this collection to our short term target state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
AirbyteServer
block [breaking-changes]AirbyteServer
block
Adds the
AirbyteServer
block to handle nginx authentication for OSS instance inAirbyteClient
and store config info about the instance running airbyte.This PR alters the tasks in this collection to accept an
AirbyteServer
instead of the individual fields, so these are breaking changes.This PR also adds a deprecation warning to
export_configuration
, as the underlying API endpoint was removed from OSS airbyte as of airbyte v0.40.7Closes #39
Closes #21
Example
Checklist