This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Refactors status code handling in Airbyte client #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
reviewed
Sep 7, 2022
Co-authored-by: Andrew <[email protected]>
ahuang11
suggested changes
Sep 7, 2022
ahuang11
approved these changes
Sep 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the status code handling in the Airbyte client to handle all non 2xx status codes. Previously, status codes that did not match the preconfigured checks would fall through and cause unexpected errors. Now, we will raise on all non 2xx status codes and handle the exceptions in specific cases.
Relevant Issue(s)
Closes #17
Checklist