Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

make sleep async #13

Merged
merged 2 commits into from
Jul 30, 2022
Merged

make sleep async #13

merged 2 commits into from
Jul 30, 2022

Conversation

ahuang11
Copy link
Contributor

Summary

I think asyncio.sleep prevents blocking

Relevant Issue(s)

Checklist

@ahuang11 ahuang11 requested a review from desertaxle July 29, 2022 21:15
@ahuang11 ahuang11 requested a review from zzstoatzz as a code owner July 29, 2022 21:15
zzstoatzz
zzstoatzz approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@ahuang11 ahuang11 merged commit 4f03afe into main Jul 30, 2022
@zzstoatzz zzstoatzz deleted the make_sleep_async branch November 15, 2022 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@zzstoatzz zzstoatzz zzstoatzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahuang11 @desertaxle @zzstoatzz