Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the current helm state to identify untracked releases #337

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

luisdavim
Copy link
Collaborator

This should fix #336.
The code could use some more cleaning but I'm trying to keep the changes to the minimum to stay out of the way of @mkubaczyk's HelmV3 PR. I think we should release this before the Helm v3 rewrite so we have a working Helm v2 version.

@luisdavim luisdavim force-pushed the cleanUntracked branch 6 times, most recently from 7a07d4c to bc6b046 Compare December 11, 2019 16:58
Copy link
Collaborator

@mkubaczyk mkubaczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF you don't want to waste time on merging changes from helmsman 3 into this, then I'm good to go with PR.

kube_helpers.go Show resolved Hide resolved
Copy link
Collaborator

@jmontroy90 jmontroy90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question or two.

kube_helpers.go Show resolved Hide resolved
@luisdavim luisdavim merged commit c3ca345 into master Dec 12, 2019
@luisdavim luisdavim deleted the cleanUntracked branch December 12, 2019 16:56
@mkubaczyk
Copy link
Collaborator

@luisdavim since your fix is merged, can we start pushing current master as legacy branch and merge helm 3 version slowly to master?

mkubaczyk pushed a commit that referenced this pull request Aug 18, 2023
use the current helm state to identify untracked releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helmsman is not deleting untracked releases
3 participants