-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies upgrade #306
Dependencies upgrade #306
Conversation
@sami-alajrami I think we should probably update the pipeline and build images for a few different versions of kubernetes. |
@chenrui333 you should probably also update the dockerfile in the |
@luisdavim I think the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now,
but at some point we should ask ourselves wether we should rush with helm or kubectl version upgrade, since 1.16.x is two major versions away from e.g. Google Kubernetes Engine stable version, which is 1.14.x and it is plausible most of clients are using Helmsman for cloud-based k8s clusters etc. :-)
I agree with @mkubaczyk probably not many people are using 1.16.x yet, helm v2.15 should be ok though. But if kubectl v1.16.x is compatible with k8s 1.14.x we should be ok. |
I see, that is good point. I am using EKS for most of stuff, and my kubectl is up to date though. |
I can certainly update back to 1.14.x |
Yeah, it's probably better for now. |
Sounds good, just revert back to v1.14.8 :) |
Thanks @luisdavim! |
Upgrade some dependencies: