Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies upgrade #306

Merged
merged 11 commits into from
Oct 22, 2019
Merged

Dependencies upgrade #306

merged 11 commits into from
Oct 22, 2019

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Oct 18, 2019

Upgrade some dependencies:

  • golang to v1.13.1
  • helm, v2.15.0
  • goreleaser v0.120.2
  • k8s, v1.16.2

@luisdavim
Copy link
Collaborator

@sami-alajrami I think we should probably update the pipeline and build images for a few different versions of kubernetes.

@luisdavim
Copy link
Collaborator

@chenrui333 you should probably also update the dockerfile in the test_files folder.

@chenrui333
Copy link
Contributor Author

@luisdavim I think the test_files folder has been updated, right?

Copy link
Collaborator

@mkubaczyk mkubaczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now,
but at some point we should ask ourselves wether we should rush with helm or kubectl version upgrade, since 1.16.x is two major versions away from e.g. Google Kubernetes Engine stable version, which is 1.14.x and it is plausible most of clients are using Helmsman for cloud-based k8s clusters etc. :-)

@luisdavim
Copy link
Collaborator

I agree with @mkubaczyk probably not many people are using 1.16.x yet, helm v2.15 should be ok though. But if kubectl v1.16.x is compatible with k8s 1.14.x we should be ok.
This is why I made the comment about providing a few different versions of the Docker image with the last 2 or 3 versions of helm and kubectl. Something like latest and stable.

@chenrui333
Copy link
Contributor Author

I see, that is good point. I am using EKS for most of stuff, and my kubectl is up to date though.

@chenrui333
Copy link
Contributor Author

I can certainly update back to 1.14.x

@luisdavim
Copy link
Collaborator

Yeah, it's probably better for now.

@chenrui333
Copy link
Contributor Author

Sounds good, just revert back to v1.14.8 :)

@luisdavim luisdavim merged commit 7e095c8 into Praqma:master Oct 22, 2019
@chenrui333
Copy link
Contributor Author

Thanks @luisdavim!

mkubaczyk pushed a commit that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants