Add appsTemplates omitempty YAML key to allow YAML anchors in state file #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
@sami-alajrami @luisdavim how you guys find it? |
|
have you tested it? as long as this doesn't break the |
|
@luisdavim yes, it's working fine with yamls while at the same time not impacting tomls at all. Should I merge then? |
mkubaczyk
added a commit
that referenced
this pull request
Aug 18, 2023
Add appsTemplates omitempty YAML key to allow YAML anchors in state file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature request #300 with ignored keys in YAML state file, where such keys can be used as YAML anchors to follow DRY rule is really valuable, so I thought of the simplest way to do this. Hence the PR I created with the least change I could do to achieve that.