Add ability to disable environment substitution in values files #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm +1 |
sami-alajrami
suggested changes
Aug 13, 2019
utils.go
Outdated
| @@ -55,7 +55,7 @@ func fromTOML(file string, s *state) (bool, string) { | |||
| } | |||
| addDefaultHelmRepos(s) | |||
| resolvePaths(file, s) | |||
| if !noEnvSubst { | |||
| if !noEnvSubst || !noEnvValuesSubst { | |||
There was a problem hiding this comment.
I think this should be && .. the current condition means that if noEnvSubst = false and noEnvValuesSubst = true , environment variables will still be substituted in values files.
There was a problem hiding this comment.
Yep, you are right - thanks.
|
@sami-alajrami fixed! |
sami-alajrami
approved these changes
Aug 13, 2019
mkubaczyk
pushed a commit
that referenced
this pull request
Aug 18, 2023
Add ability to disable environment substitution in values files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to disable environment substitution in values files.
Resolves #280