Do not delete untracked releases if the target flag is set. #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sami-alajrami Do you have a minute to look at this PR? 🙂 |
|
@fmotrifork apologies it took so long to get around it. Thank you for the contribution! |
mkubaczyk
pushed a commit
that referenced
this pull request
Aug 18, 2023
Do not delete untracked releases if the target flag is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
-targetflag does not ignore untracked releases, even when specifically stating which release we are targeting.Releases that are not specified by a
-targetflag is now also ignored.I have added tests for the
-targetflag behaviour defined in thedecision_maker.gofile, but I am unfortunately not able to write a test for-targetflag for untracked releases, in the way the code is structured today.I was thinking that maybe the
func cleanUntrackedReleases()inhelm_helpershould actually be a part of thedecide(r,s)func so that all decisions are made when building the plan?