Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages with a VS Code engine bump to 1.96 #5126

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update packages with a VS Code engine bump to 1.96 #5126

merged 1 commit into from
Jan 16, 2025
+276 −266

Conversation

andyleejordan
Copy link
Member

See title.

@Copilot Copilot bot review requested due to automatic review settings January 15, 2025 21:34
@andyleejordan andyleejordan requested a review from a team as a code owner January 15, 2025 21:34
Copilot
Copilot AI reviewed Jan 15, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
@andyleejordan andyleejordan force-pushed the package-updates branch 3 times, most recently from e1b951c to 206ff87 Compare January 16, 2025 17:50
@andyleejordan
Update packages with a VS Code engine bump to 1.96
16deb06 
With new string casts to quiet new warnings.
@andyleejordan andyleejordan enabled auto-merge (rebase) January 16, 2025 18:02
@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Jan 16, 2025
SeeminglyScience
SeeminglyScience approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit a1e279b into main Jan 16, 2025
7 checks passed
@andyleejordan andyleejordan deleted the package-updates branch January 16, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @SeeminglyScience