Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Optimize Launch Configs and Enable Hot Reload #5094

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented Nov 18, 2024

Improvements to the developer inner loop experience for the extension.
Needs: PowerShell/PowerShellEditorServices#2202

Tip

To test this PR you need to build the extension and install it, as it adds some new commands and configs. Here is a pre-built VSIX

Launch Config Pre-Launch Tasks

The regular, temp, and isolated launch configurations have been optimized two prelaunch tasks:

  • A esbuild watch for vscode-powershell to detect code changes and rebuild the extension
  • A invoke-build task for PSES that rebuilds the extension only if changes to the source have been detected since the last build.

Auto-Attach PSES Debugger

The launch configurations now auto-attach the PSES debugger rather than prompting for a PID.

Capture.mp4

Auto Extension Restart on Changes

When the extension is running in dev (debug) mode, changes to the extension files auto-trigger an extension host restart. In temp and isolated, this is pretty fast especially compared to a window reload.

Capture.mp4

PSES Hot Reload

Hot Reload is now enabled, allowing testing of in-flight changes. Really handy for Handler development.

Capture.mp4

Other Changes

  • The .vscode folder configuration has been merged into the code-workspace file due to limitations in calling tasks from code-workspace launch configs. All devs should be using the code-workspace file anyways.
  • Docs were updated to provide clarify on these changes
  • The workspace file was renamed in order to be more clear this is specifically for the vscode-powershell extension.
    image

@JustinGrote JustinGrote self-assigned this Nov 18, 2024
@JustinGrote JustinGrote changed the title Optimize Launch Configs and Enable Hot Reload Dev: Optimize Launch Configs and Enable Hot Reload Nov 18, 2024
@JustinGrote JustinGrote marked this pull request as ready for review November 18, 2024 19:42
@JustinGrote JustinGrote requested a review from a team as a code owner November 18, 2024 19:42
@JustinGrote JustinGrote force-pushed the justingrote/feature/betterWorkspaceConfig branch from 6b30cca to 6c50282 Compare November 18, 2024 19:49
@JustinGrote JustinGrote added the Issue-Enhancement A feature request (enhancement). label Nov 18, 2024
@JustinGrote JustinGrote force-pushed the justingrote/feature/betterWorkspaceConfig branch 3 times, most recently from a3ad00f to ab06afd Compare November 19, 2024 03:12
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, excited to use it.

@JustinGrote JustinGrote force-pushed the justingrote/feature/betterWorkspaceConfig branch from 0b4595c to d611a44 Compare November 22, 2024 00:58
@JustinGrote JustinGrote force-pushed the justingrote/feature/betterWorkspaceConfig branch 2 times, most recently from ea67e43 to d63e652 Compare November 22, 2024 01:09
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing.

@JustinGrote JustinGrote force-pushed the justingrote/feature/betterWorkspaceConfig branch from d63e652 to f44d99f Compare November 22, 2024 05:03
@JustinGrote JustinGrote enabled auto-merge (rebase) November 22, 2024 05:05
@JustinGrote JustinGrote merged commit 7aae792 into main Nov 22, 2024
7 checks passed
@JustinGrote JustinGrote deleted the justingrote/feature/betterWorkspaceConfig branch November 22, 2024 05:09
@JustinGrote
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants