Fix New-EditorFile with no folder or no files open #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
reviewed
Apr 8, 2019
module/PowerShellEditorServices/Commands/Public/CmdletInterface.ps1
Outdated
Show resolved
Hide resolved
rjmholt
approved these changes
Apr 8, 2019
rjmholt
pushed a commit
to rjmholt/PowerShellEditorServices
that referenced
this pull request
Apr 9, 2019
* Fix New-EditorFile with no folder or no files open * address rob's feedback
rjmholt
pushed a commit
to rjmholt/PowerShellEditorServices
that referenced
this pull request
Apr 10, 2019
* Fix New-EditorFile with no folder or no files open * address rob's feedback
rjmholt
pushed a commit
that referenced
this pull request
Apr 10, 2019
* Fix New-EditorFile with no folder or no files open * address rob's feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the file that gets passed in is relative... When it's relative, it hits this piece of code:
https://github.com/PowerShell/vscode-powershell/blob/d02adc54b1f20d2da7cd5efddae3c0a8400ffe2d/src/features/ExtensionCommands.ts#L533-L536
When it does and there is not Folder or File open in the editor,
vscode.workspace.rootPathis set toundefinedand thus causes something likeNew-EditorFile -Path ./foo.txtto fail.With this change, we resolve any filepaths passed in first before sending them to the client.
fixes #905