Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unhandled messages to Warning #767

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Oct 10, 2018

Resolves PowerShell/vscode-powershell#1572.

Unhandled messages are tolerated in the LSP and we know about the major ones. Having them as an error is distracting in the logs, so this changes the report to a warning.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit f0cb9fa into PowerShell:master Oct 11, 2018
@rjmholt rjmholt deleted the message-errors-warnings branch December 12, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants