Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix load order of PSSA modules #705

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Fix load order of PSSA modules #705

merged 1 commit into from
Jul 15, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jul 14, 2018

Current bug means we always load the oldest version of PSSA.

Now we will load the newest.

rkeithhill
rkeithhill approved these changes Jul 14, 2018
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but then again, I said that the first time around. :-(

TylerLeonhardt
TylerLeonhardt approved these changes Jul 15, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rkeithhill
Copy link
Contributor

Well, this is surprising:

Build execution time has reached the maximum allowed time for your plan (180 minutes).

Build must have gotten hung of the build machine was under a seriously heavy load.

@TylerLeonhardt
Copy link
Member

Looks like we're all good now

@TylerLeonhardt TylerLeonhardt merged commit 5a371f3 into PowerShell:master Jul 15, 2018
@rjmholt rjmholt deleted the pssa-module-load-fix branch December 12, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@rkeithhill rkeithhill rkeithhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjmholt @rkeithhill @TylerLeonhardt