Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look in all workspace folders for PSSA settings file #2167

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

andyleejordan
Copy link
Member

Mostly investigating PowerShell/vscode-powershell#4743.

@andyleejordan andyleejordan force-pushed the main branch 2 times, most recently from 80b2351 to 9ce8911 Compare November 18, 2024 19:05
@andyleejordan andyleejordan changed the title WIP: Look in all workspace folders for PSSA settings file Look in all workspace folders for PSSA settings file Jan 8, 2025
@andyleejordan andyleejordan added the Issue-Bug A bug to squash. label Jan 8, 2025
@andyleejordan andyleejordan force-pushed the andyleejordan/pssa-settings branch from fdaadb8 to d29fded Compare January 8, 2025 18:58
@andyleejordan
Copy link
Member Author

@JustinGrote @SeeminglyScience would you two mind reviewing this? I think there's reason enough to get it in. It doesn't fix everything since the logic is just "find the first PSSA config" and not a specific folder's config, but the latter is a big ask and the former at least gives a solution to multi-root repos. And it's come up a few times now.

@andyleejordan andyleejordan enabled auto-merge (squash) January 8, 2025 19:00
@JustinGrote
Copy link
Collaborator

@andyleejordan I couldn't really tell but does it look thru the workspaces in a deterministic fashion? My thought was that since you can specify the folder order in the workspace, if it always goes thru the folder order, then a user can define the "primary" analyzer by putting that folder to the top.

Also agreed a per-folder analysis config that also applies different rules to each folder is a way larger ask.

@andyleejordan andyleejordan force-pushed the andyleejordan/pssa-settings branch from d29fded to 0078743 Compare January 8, 2025 21:34
@andyleejordan
Copy link
Member Author

Yes, it should iterate over the workspace folders deterministically and in the order supplied. So you're right, you can force it by ordering those in the workspace settings.

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit aef0fc2 into main Jan 10, 2025
8 checks passed
@andyleejordan andyleejordan deleted the andyleejordan/pssa-settings branch January 10, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants