Fix New-EditorFile adding content in current file #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object returned from GetEditorContext() always points to the original file in CurrentFile. We need to get an updated object after opening or creating a file to insert text in the right editor. Fix PowerShell/vscode-powershell#3192
PowerShell#869 forgot to assign a returned editorcontext, causing new output from the command. Assigning to null.
andyleejordan
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Ah, great fix, thanks @fflaten! (Also I spy yet another file I didn't even know existed 🤫)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Updates
New-EditorFileto insert text in the newly created editor as intended.Also took the liberty to drop the
EditorContext-object currently being returned fromOut-CurrentFileafter #869. I'm 99% sure that's unintended 🙂 /cc @dfinkePR Context
Fix PowerShell/vscode-powershell#3192