-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul workspace search for symbol references #1917
Merged
andyleejordan
merged 6 commits into
PowerShell:main
from
SeeminglyScience:workspace-scan-overhaul
Sep 15, 2022
Merged
Overhaul workspace search for symbol references #1917
andyleejordan
merged 6 commits into
PowerShell:main
from
SeeminglyScience:workspace-scan-overhaul
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
src/PowerShellEditorServices/Services/PowerShell/Utility/CommandHelpers.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/TextDocument/Handlers/TextDocumentHandler.cs
Show resolved
Hide resolved
andyleejordan
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
src/PowerShellEditorServices/Services/PowerShell/Utility/CommandHelpers.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShell/Utility/CommandHelpers.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/TextDocument/Handlers/DidChangeWatchedFilesHandler.cs
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/TextDocument/Handlers/TextDocumentHandler.cs
Show resolved
Hide resolved
…ndHelpers.cs Co-authored-by: Andy Jordan <[email protected]>
…ndHelpers.cs Co-authored-by: Andy Jordan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Dependent on PowerShell/vscode-powershell#4170
Significantly reduce performance overhead of reference finding in large workspaces.
PR Context
This PR has the following changes:
ScriptFile
Did*TextDocument
notificationsDid*TextDocument
notifications.As a stress test I opened up my profile directory (which has ~3k script files in total in the
Modules
directory) and created a file with a function definition on every line. I then tabbed to a different file, and then tabbed back to the new file. Before the changes, the references code lens took ~10 seconds to populate and my CPU spiked to ~50% usage. After the changes, they populated instantly and CPU spiked to ~2% usage.