Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end-to-end Pester unit test #1846

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Add end-to-end Pester unit test #1846

merged 1 commit into from
Jul 1, 2022

Conversation

andyleejordan
Copy link
Member

I couldn't actually get #1672 to repro, but I did add a comprehensive end-to-end test for running a Pester test file.

@andyleejordan andyleejordan requested review from a team and JustinGrote June 27, 2022 22:24
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Jun 27, 2022
@andyleejordan andyleejordan force-pushed the andschwa/tests branch 2 times, most recently from d08b0cc to 52e2455 Compare June 27, 2022 22:48
JustinGrote
JustinGrote approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@JustinGrote JustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in a place to run it right now but your logic looks sound to me.

@andyleejordan
Copy link
Member Author

🤞 these tests pass...seems just flaky as it works locally 😓

@andyleejordan
Copy link
Member Author

Well, seems to be a Windows issue now. Maybe because old Pester versions in-box?

@andyleejordan andyleejordan requested a review from a team as a code owner June 28, 2022 20:09
@andyleejordan andyleejordan force-pushed the andschwa/tests branch 19 times, most recently from 5bef806 to d483736 Compare June 30, 2022 23:52
@andyleejordan andyleejordan force-pushed the andschwa/tests branch 2 times, most recently from f5b370a to c274c94 Compare July 1, 2022 00:21
@andyleejordan
Copy link
Member Author

Ok, I give up, skipping on Windows. @SeeminglyScience please review!

@andyleejordan andyleejordan enabled auto-merge (squash) July 1, 2022 20:10
@andyleejordan andyleejordan merged commit 4e4fdc3 into main Jul 1, 2022
@andyleejordan andyleejordan deleted the andschwa/tests branch July 1, 2022 20:29
@andyleejordan andyleejordan mentioned this pull request Aug 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinGrote JustinGrote JustinGrote approved these changes

Assignees
No one assigned
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @JustinGrote