Apply automatic fixes (manually) #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
commented
Apr 13, 2022
| @@ -111,8 +109,7 @@ public static string GenerateValidNamedPipeName(IReadOnlyCollection<string> pref | |||
| { | |||
| return pipeName; | |||
| } | |||
|
|
|||
| } while (tries < 10); | |||
There was a problem hiding this comment.
This was never incrementing tries and therefore had actually been an infinite loop.
andyleejordan
commented
Apr 13, 2022
| @@ -132,15 +124,13 @@ private EditorServicesServerFactory(ILoggerFactory loggerFactory, LogLevel minim | |||
| public PsesDebugServer RecreateDebugServer( | |||
| Stream inputStream, | |||
| Stream outputStream, | |||
| PsesDebugServer debugServer, | |||
| bool usePSReadLine) | |||
There was a problem hiding this comment.
Apparently we don't use usePSReadLine at all.
|
<200 "problems" now! |
andyleejordan
commented
Apr 13, 2022
| @@ -128,8 +128,7 @@ public async Task<SetFunctionBreakpointsResponse> Handle(SetFunctionBreakpointsA | |||
| CommandBreakpointDetails[] breakpointDetails = request.Breakpoints | |||
| .Select((funcBreakpoint) => CommandBreakpointDetails.Create( | |||
| funcBreakpoint.Name, | |||
| funcBreakpoint.Condition, | |||
| funcBreakpoint.HitCondition)) | |||
There was a problem hiding this comment.
Last param was unused in the function.
andyleejordan
commented
Apr 13, 2022
| await debugInfoHandle.WaitAsync().ConfigureAwait(false); | ||
| try | ||
| { | ||
| variableContainer = (VariableContainerDetails)variables[variableContainerReferenceId]; | ||
| // OK, now we have a PS object from the supplied value string (expression) to assign to a variable. | ||
| // Get the variable referenced by variableContainerReferenceId and variable name. |
There was a problem hiding this comment.
Sorry this file might conflict with your PR.
andyleejordan
added
Issue-Enhancement
These were available in code lens style "click to fix" but were not applied by the CLI tools. It was slow, but not horrible. Also silence two annoying suggestions around comments and naming.
andyleejordan
force-pushed
the
andschwa/auto-fixes
branch
from
b9abf59 to
5eb74fe
Compare
And now only 75! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were available in code lens style "click to fix" but were not
applied by the CLI tools. It was slow, but not horrible.