Re-workaround uncancellable Console.ReadKey
#1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
approved these changes
Apr 5, 2022
So far, yeah. |
|
Oh right WIP OOPS 😁 |
This "rewrite" uses the `console.sendText()` API in VS Code to respond to a notification and send a fake key press, allowing us to "cancel" `ReadKey` by getting it to return. Since we know we requested the cancellation, we just drop the fake key press. This means we no longer have to poll on macOS/Linux, and no longer have the ghost "double key-press" issue on Windows. This fixes a myriad of problems and opens up a lot of simplification.
So much simpler.
andyleejordan
force-pushed
the
andschwa/readkey
branch
from
430f6f6 to
9fa13a2
Compare
andyleejordan
changed the title
Console.ReadKeyConsole.ReadKey
SeeminglyScience
approved these changes
Apr 8, 2022
src/PowerShellEditorServices/Services/PowerShell/Console/ConsoleProxy.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShell/Console/ConsoleProxy.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs
Outdated
Show resolved
Hide resolved
andyleejordan
force-pushed
the
andschwa/readkey
branch
from
e3278a8 to
7c97b9a
Compare
|
Yay! Thanks @SeeminglyScience. Merging. |
daxian-dbw
reviewed
Apr 20, 2022
src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs
Show resolved
Hide resolved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pulled out the old native
UnixConsoleEchoand I think finished #1745, then removed all theReadKeyAsynccode that was unreferenced. Currently testing using theKeyAvailableworkaround on Windows, and testing the bufferedReadKeyworkaround on macOS. They're both broken in different ways 🤷