Use EditorConfig for dotnet build and suppress existing issues #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using `silence` we now use `suggestion` which enables Roslynator and other tools to continue to show the warning, but not block the build. This allows us to set `EnforceCodeStyleInBuild` now, without having to fix everything, which helps prevent future mistakes. Note that many of these should be fixed ASAP, and that we previously thought we'd enabled all the maintainability warnings, but since they are not turned on by default, the category does nothing. Co-authored-by: Andy Schwartzmeyer <[email protected]>
andyleejordan
force-pushed
the
suppressExistingIssues
branch
from
de499fc to
023e51b
Compare
|
Woo! Thanks for this @JustinGrote. I added documentation to all the suggestions added, and used the |
Sounds good! Forgot about common.props |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will configure the various .NET projects to use the editorconfig suppression settings, and adds several to demote existing (but working) warnings to suggestions, including rosylnator.
This is just meant as a stop-gap to ensure that dotnet build in CI looks "clean", so that finding/inspecting errors takes less time. Next step is to go back and selectively remove the warnings and either fix the code or drop a selective exception in for that particular warning. "Net-New" warning categories not already present in the current code have not been demoted and will continue to be reported as such.
With this, the VSCode is no longer a sea of yellow warnings, so when working on a PR it's much easier to see where specifically your code has issues. All issues are still reported as suggestions however (currently 1273 total...) but that can be easily toggled as a filter in VSCode Problems pane.
