Bump version to v2.4.5
#1508
Merged
Bump version to v2.4.5
#1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
release/v2.4.5
branch
from
6ed1512 to
08d201c
Compare
|
Fixes #1509 |
|
Ugh, our flaky tests are becoming flakier. |
rjmholt
approved these changes
Jun 23, 2021
andyleejordan
force-pushed
the
release/v2.4.5
branch
from
7634afc to
7f7cb71
Compare
We only run builds on ADO with the intent to release, therefore we need to just always sign them. Otherwise the compliance scripts' default behavior is to sign when the build is manually triggered, which is not our workflow. We push a release branch and expect that automatic build to result in signing.
andyleejordan
force-pushed
the
release/v2.4.5
branch
from
7f7cb71 to
d862af8
Compare
andyleejordan
force-pushed
the
release/v2.4.5
branch
from
d862af8 to
3a97dce
Compare
|
Heh @rjmholt I missed a spot, there are two places we need |
rjmholt
approved these changes
Jun 23, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only run builds on ADO with the intent to release, therefore we need to just
always sign them. Otherwise the compliance scripts' default behavior is to sign
when the build is manually triggered, which is not our workflow. We push a
release branch and expect that automatic build to result in signing.