Address breaking changes in Omnisharp lib and depend on DocumentUri more #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
May 27, 2020
| @@ -147,7 +146,7 @@ internal static string GetUniqueIdFromDiagnostic(Diagnostic diagnostic) | |||
| EnsureEngineSettingsCurrent(); | |||
|
|
|||
| // Create a cancellation token source that will cancel if we do or if the caller does | |||
There was a problem hiding this comment.
The comment here is no longer true with the CreateLinked method removed
There was a problem hiding this comment.
removed the comment. This is no longer needed because it's not really possible to cancel a didChange notification.
Comment on lines
55
to
58
| var capabilities = typeof(ICapability).Assembly.GetExportedTypes() | ||
| .Where(z => typeof(ICapability).IsAssignableFrom(z)) | ||
| .Where(z => z.IsClass && !z.IsAbstract); | ||
| foreach (var item in capabilities) |
There was a problem hiding this comment.
What are the vars here? Possible to change them to explicit types?
There was a problem hiding this comment.
updated. Also added a comment that this code is temporary.
|
Issues
======
+ Solved 2
- Added 1
Complexity increasing per file
==============================
- test/PowerShellEditorServices.Test.E2E/Processes/StdioServerProcess.cs 4
- test/PowerShellEditorServices.Test.E2E/LSPTestsFixures.cs 2
- test/PowerShellEditorServices.Test.E2E/Processes/ServerProcess.cs 2
Clones removed
==============
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/FormattingHandlers.cs -3
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/DocumentSymbolHandler.cs -2
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeLensHandlers.cs -2
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/HoverHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/FoldingRangeHandler.cs -2
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/DefinitionHandler.cs -2
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/SignatureHelpHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/ReferencesHandler.cs -1
+ src/PowerShellEditorServices/Services/Workspace/Handlers/WorkspaceSymbolsHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/DocumentHighlightHandler.cs -1
See the complete overview on Codacy |
TylerLeonhardt
commented
May 27, 2020
rjmholt
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main parts
Address breaking changes
Depend on DocumentUri more
DocumentUritype instead of a string