Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temp debugging after it broke bringing in $psEditor #1150

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jan 9, 2020

Fixes PowerShell/vscode-powershell#2402

Apparently, when I added $psEditor back in, I broke Temp debugging again...

Now it works. The main changes are:

  • Add a null ILanguageServer to the service collection so that the EditorOperationsService has something to retrieve
  • If the languageServer is null, warn the user to use the main PowerShell Integrated Console
  • Bring in @rjmholt 's change in [WIP] Fix temp debugging startup #1148
  • Actually have $psEditor be available in the console by triggering the creation of the service that sets the psvariable

@TylerLeonhardt
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/PowerShellContext/EditorOperationsService.cs  1
         

See the complete overview on Codacy

@TylerLeonhardt
Copy link
Member Author

hopefully this is the last time I have to fix temp debugging lol

@TylerLeonhardt TylerLeonhardt merged commit 6e52a9d into PowerShell:master Jan 9, 2020
@TylerLeonhardt TylerLeonhardt deleted the fix-temp-debugging-after-pseditor branch January 9, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to start debugging interactive session
2 participants