Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PSRL to 2.0.0-rc1 #1129

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Update PSRL to 2.0.0-rc1 #1129

merged 1 commit into from
Dec 11, 2019

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Dec 11, 2019

No description provided.

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -10,7 +10,7 @@
"AllowPrerelease":false
},
"PSReadLine":{
"MinimumVersion":"2.0.0-beta6",
"MinimumVersion":"2.0.0-rc1",
"MaximumVersion":"2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why there are two maximumversion entries?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daxian-dbw where do you see a second maximum version entry?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I misread the MinimumVersion entry :)

@rjmholt rjmholt merged commit 9093fd1 into PowerShell:master Dec 11, 2019
@rjmholt rjmholt deleted the psrl-2rc1 branch December 12, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants