Alt: Handle clearTerminal message by using vscode clear command #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
|
Issues
======
+ Solved 1
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/PowerShellContext/Extensions/EditorTerminal.cs 1
See the complete overview on Codacy |
rjmholt
approved these changes
Nov 21, 2019
| ) | ||
|
|
||
| __clearhost | ||
| if ($All.IsPresent) { |
There was a problem hiding this comment.
Is there a good reason to include .IsPresent?
There was a problem hiding this comment.
I think strict mode requires this.
|
went the other way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an "issue" that comes up a lot that when you
Clear-Hostand are still able to scroll up.This is an alt of #1108
Instead, this doesn't use a vscode setting and allows the user to do
-Allto clear the scrollback buffer as well.Pairs with: PowerShell/vscode-powershell#2318