Catch stream exceptions for some Debug Adapter stability. #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
rkeithhill,
rjmholt and
SeeminglyScience
TylerLeonhardt
changed the title
SeeminglyScience
approved these changes
Sep 9, 2019
| e is IOException) | ||
| { | ||
| // We catch this exception for when the DebugAdapter disconnects while still processing a message. | ||
| logger.WriteException("Tried to write to the output stream but it was already closed & broken.", e); |
There was a problem hiding this comment.
This probably happens decently often, do we want to make this a verbose message? If you can't include an exception in the verbose message then never mind.
There was a problem hiding this comment.
verbose doesn't allow an exception but I did change this to WriteHandledException!
rjmholt
approved these changes
Sep 10, 2019
rjmholt
approved these changes
Sep 15, 2019
TylerLeonhardt
added a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Sep 16, 2019
…#1022) * catch stream exceptions for Debug Adapter * Use WriteHandledException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps protect from a crash we were seeing with the "Start without debugging" feature in VS Code.