-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UseCorrectCasing: Fix wildcard lookups for command lookup and do not append .exe for applications on Windows #1210
Merged
bergmeister
merged 6 commits into
PowerShell:development
from
bergmeister:DoNotCorrectCasingOfAliases
Apr 16, 2019
Merged
UseCorrectCasing: Fix wildcard lookups for command lookup and do not append .exe for applications on Windows #1210
bergmeister
merged 6 commits into
PowerShell:development
from
bergmeister:DoNotCorrectCasingOfAliases
Apr 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correct application names to end in .exe on Windows
@bergmeister Thanks for fixing issue. In very rare cases, I think the following codes may still produce unexpected results. > Invoke-Formatter '?et-Content $file'
Get-Content $file
> Invoke-Formatter 'Get-* $file'
Get-AppPackage $file How about we consider using |
@mkht Thanks for the useful suggestion, I did not know that such an API existed, I applied it |
rjmholt
reviewed
Apr 8, 2019
rjmholt
approved these changes
Apr 9, 2019
rjmholt
reviewed
Apr 10, 2019
…e isWindows variable better
rjmholt
approved these changes
Apr 15, 2019
Co-Authored-By: bergmeister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
UseCorrectCasing: Fix command lookups using wildcards, e.g. ? would've wrongly returned ForEach-Object and do not append .exe to binaries on Windows
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.