Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in tooltip rendering related to calculation of the tooltip height #3671

Merged
merged 1 commit into from
May 3, 2023

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented May 3, 2023

PR Summary

Fix a bug in tooltip rendering related to calculation of the tooltip height.
The tooltip height calculation is wrong due to my mistake on the precedence order of the ternary operator, which resulted in the clearance of list view not work as expected.

Before:

image

After:

image

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 6b7c48a into PowerShell:master May 3, 2023
@daxian-dbw daxian-dbw deleted the fix branch May 3, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant