-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add support for upcasing, downcasing, and capitalizing word #3365
Conversation
@lzybkr Hi, again. Some of the requirements have not been fulfilled (writing tests, adding docs). I need help with that. And being unfamiliar with the codebase, what I've come up with must be riddled with bugs. Need review on the actual code, too. You understand. |
@3N4N - thanks for the contribution - @daxian-dbw is the PSReadLine maintainer now. |
Any chance of it getting reviewed? An update would be nice. |
@3N4N thanks for submitting the PR, we will review it the next Monday. Every Monday is our community day, where we focus on PRs and issues. |
Thanks. |
ac0734d
to
baef10d
Compare
All suggestions except the tests have been committed. I'll get to the tests soon. |
@daxian-dbw All suggestions committed. Tests for all three functions added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I pushed a commit to fix up a few minor issues, and also added descriptions for the new public functions.
Thanks @daxian-dbw for the merge. |
The change in PowerShell/PSReadLine#3365 added three new functions for modifying the casing of text with PSReadLine. This change: - Adds an entry for each new function in the "Basic editing functions" section of `about_PSReadLine_Functions.md` - Resolves MicrosoftDocs#9033 - Resolves AB#4387
The change in PowerShell/PSReadLine#3365 added three new functions for modifying the casing of text with PSReadLine. This change: - Adds an entry for each new function in the "Basic editing functions" section of `about_PSReadLine_Functions.md` - Resolves #9033 - Resolves AB#4387
🎉 |
PR Summary
Closes #2912
GNU Readline provides functionalities which let the user change the case of the word in front of the cursor. They can change the word to upper case or lower case, or they can capitalize it. The keybindings by default provided are as follows.
This PR brings that functionality to PSReadLine.
The newly added bindable functions are in the "Basic editing functions" section:
PR Checklist
Microsoft Reviewers: Open in CodeFlow