Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the cancellation related code #3280

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Update the cancellation related code #3280

merged 1 commit into from
Apr 19, 2022

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Apr 19, 2022 •
edited by ghost
Loading

PR Summary

Refactor the code related to cancellation a little bit.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw
Copy link
Member Author

@andschwa This is a refactoring change to the cancellation related code. Please review.

andyleejordan
andyleejordan approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested, still working as desired for PSES.

@andyleejordan andyleejordan merged commit 703f7a4 into PowerShell:master Apr 19, 2022
@daxian-dbw daxian-dbw deleted the cancel branch April 19, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daxian-dbw @andyleejordan