Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to clear lines when it's not a menu completion rendering #3199

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Feb 1, 2022

PR Summary

Fix #3196
No need to clear lines when it's not a menu completion rendering.

The fix is simply moving the code that handles line cleanup for menu movement to the if (menuSelect) block.
It's much easier to review when ignoring white space changes: https://github.com/PowerShell/PSReadLine/pull/3199/files?w=1

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 39761f9 into PowerShell:master Feb 2, 2022
@daxian-dbw daxian-dbw deleted the regress branch February 2, 2022 18:38
@ghost
Copy link

ghost commented Feb 22, 2022

🎉 v2.2.2 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blank lines after output of ctrl+space
2 participants