Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with updated links to content helping get set up #3149

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

cgorshing
Copy link
Contributor

@cgorshing cgorshing commented Jan 12, 2022

PR Summary

I felt the README links could be updated with a video showing more recent features. John Savill's video helped me get more things set up for my env and showed what was possible.

I added dates, this is subjective and obviously can easily be determined by visiting the links, I just thought having something to show how well those relate to the current state of PSReadLine. Maybe specifying what version of PSReadLine those articles relate to would be another option. I can remove them if felt as though they do not belong.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw
Copy link
Member

That looks great! Thank you!

@daxian-dbw daxian-dbw merged commit 4c02d5c into PowerShell:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants