Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HistorySearchBackward and HistorySearchForward able to navigate the prediction list view #3144

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Make HistorySearchBackward and HistorySearchForward able to navigate the prediction list view #3144

merged 1 commit into from
Jan 11, 2022

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jan 11, 2022 •
edited by ghost
Loading

PR Summary

Fix #1933

The UpArrow and DownArrow are bound to PreviousHistory and NextHistory by default, However, it's not uncommon for users to re-bind UpArrow and DownArrow to HistorySearchBackward and HistorySearchForward, and in that case, navigating the prediction list view would be broken.

This PR makes HistorySearchBackward and HistorySearchForward able to navigate the prediction list view, just like PreviousHistory and NextHistory.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw mentioned this pull request Jan 11, 2022
Closed
@daxian-dbw
Copy link
Member Author

@andschwa Please review when you have time. Thanks!

andyleejordan
andyleejordan approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests!

@daxian-dbw daxian-dbw merged commit 0824ad1 into PowerShell:master Jan 11, 2022
@daxian-dbw daxian-dbw deleted the history branch January 11, 2022 23:38
@ghost
Copy link

ghost commented Jan 28, 2022

🎉 v2.2.1-rc1 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PredictionViewStyle allow combined List and Inline or keybinding to adhoc turn use the List view
2 participants
@daxian-dbw @andyleejordan