Fix 2 menu completion issues that happen when we need to scroll screen buffer #2949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #2928
Fix #2948
The details of the issues and root cause can be found at #2928 (comment) and #2948 (comment)
Major changes in this PR:
MoveCursorToStartDrawingPosition
and used it for both menu completion and dynamic help.PreviousTop
correctly beforeTop
is changed, and get rid ofbufferEndPoint.Y
because we should compareTop
withPreviousTop
to determine if menu moved.PR Checklist
- Cannot add tests because we cannot mimic buffer scrolling with the testing console, but I manually validated the fix
Microsoft Reviewers: Open in CodeFlow