Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the exception format to make it work better with the new bug template #2917

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Oct 11, 2021

PR Summary

With the new bug template, the exception report printed by PSReadLine is supposed to be copied to the "Exception report" section which uses console render. So there is no need to warp the keys and exception stack trace in code blocks (backticks).
Also fix a typo.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit d9cc944 into PowerShell:master Oct 11, 2021
@daxian-dbw daxian-dbw deleted the minor branch October 11, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant